karx/dircord
1
0
Fork 4
Code Issues 2 Pull requests 1 Projects Releases Wiki Activity

fix all clippy lints and improve code quality #19

Merged
karx merged 3 commits from missing/dircord:master into master 2022-06-15 13:23:33 -05:00
Conversation 8 Commits 3 Files changed 1 +487 -652
missing commented 2022-06-15 12:57:51 -05:00
Contributor
Copy link

add .gitignore

add .gitignore
missing added 1 commit 2022-06-15 12:57:52 -05:00
karx commented 2022-06-15 13:02:29 -05:00
Owner
Copy link

Can you refactor lines 96 and 97 to use first_char instead of the first byte?

Can you refactor lines 96 and 97 to use `first_char` instead of the first byte?
missing commented 2022-06-15 13:03:59 -05:00
Author
Contributor
Copy link

Can you refactor lines 96 and 97 to use first_char instead of the first byte?

whoops, i think i changed that in the process of fixing the "panic on funny nickname" issue but i see that it makes no difference

> Can you refactor lines 96 and 97 to use `first_char` instead of the first byte? whoops, i think i changed that in the process of fixing the "panic on funny nickname" issue but i see that it makes no difference
missing added 1 commit 2022-06-15 13:04:31 -05:00
karx commented 2022-06-15 13:06:18 -05:00
Owner
Copy link

You can probably remove the block at line 335

You can probably remove the block at line 335
missing commented 2022-06-15 13:07:43 -05:00
Author
Contributor
Copy link

You can probably remove the block at line 335

no, if i do so the lock will be held until the end of the fn, through the select!

> You can probably remove the block at line 335 no, if i do so the lock will be held until the end of the `fn`, through the `select!`
karx commented 2022-06-15 13:10:26 -05:00
Owner
Copy link

code

I meant actually use the first_char that you compute using the loop (this is for people with unicode nicknames btw)

![code](https://cdn.discordapp.com/attachments/846061871843770460/986693787743059998/zdiupload.png) I meant actually use the first_char that you compute using the loop (this is for people with unicode nicknames btw)
karx commented 2022-06-15 13:11:17 -05:00
Owner
Copy link

You can probably remove the block at line 335

no, if i do so the lock will be held until the end of the fn, through the select!

Yeah you're right, I didn't see that

> > You can probably remove the block at line 335 > > no, if i do so the lock will be held until the end of the `fn`, through the `select!` Yeah you're right, I didn't see that
missing added 1 commit 2022-06-15 13:12:43 -05:00
missing commented 2022-06-15 13:13:47 -05:00
Author
Contributor
Copy link

code

I meant actually use the first_char that you compute using the loop (this is for people with unicode nicknames btw)

first_char in the loop was not actually the first char: it was the offset to the end of the first char, or the offset to the start of the second char. fixed up the weird naming and also used char_indicies for the second_char_offset

> ![code](https://cdn.discordapp.com/attachments/846061871843770460/986693787743059998/zdiupload.png) > > I meant actually use the first_char that you compute using the loop (this is for people with unicode nicknames btw) `first_char` in the loop was not actually the first char: it was the offset to the end of the first char, or the offset to the start of the second char. fixed up the weird naming and also used `char_indicies` for the `second_char_offset`
👍 1
karx commented 2022-06-15 13:20:02 -05:00
Owner
Copy link

Alright LGTM, merging

Alright LGTM, merging
karx merged commit 638a57bfeb into master 2022-06-15 13:23:33 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: karx/dircord#19
No description provided.
Delete branch "missing/dircord:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?