C4TG1RL5_UN1T3D/tmtd
4
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

(draft) famfos-sql-fuckery #2

Closed
famfo wants to merge 6 commits from famfos-sql-fuckery into master
pull from: famfos-sql-fuckery
merge into: C4TG1RL5_UN1T3D:master
Conversation 1 Commits 6 Files changed 13 +224 -24
famfo commented 2022-05-01 14:11:41 -05:00
Owner
Copy link

I did something, review pls senpai.

I did something, review pls senpai.
famfo added 3 commits 2022-05-01 14:11:42 -05:00
famfo requested review from lemonsh 2022-05-01 14:11:56 -05:00
karx reviewed 2022-05-01 14:17:07 -05:00
src/database.rs
@ -53,0 +68,4 @@
.await?;
return Ok(user.id)
}
Err(anyhow::anyhow!("Username is longer then 16 characters"))
karx commented 2022-05-01 14:17:07 -05:00
Owner
Copy link

I think this limit should be enforced in the frontend

I think this limit should be enforced in the frontend
famfo commented 2022-05-01 14:20:45 -05:00
Author
Owner
Copy link

So why shouldn't this check be here then?

So why shouldn't this check be here then?
karx commented 2022-05-01 14:22:18 -05:00
Owner
Copy link

Because it's redundant

Because it's redundant
famfo commented 2022-05-02 12:05:16 -05:00
Author
Owner
Copy link

I currently don't see a reason to not have it, since it is currenlty not handled on the front end.

I currently don't see a reason to not have it, since it is currenlty not handled on the front end.
karx commented 2022-05-02 12:29:28 -05:00
Owner
Copy link

Alright then, change then to than at least

Alright then, change `then` to `than` at least
karx reviewed 2022-05-01 14:18:31 -05:00
templates/task/create_task.html Outdated
@ -21,3 +21,3 @@
<label for="description">Description</label><br>
<textarea rows="3" cols="30" name="description" id="description"></textarea><br>
<textarea rows="3" cols="30" name="description" id="description"><br>
karx commented 2022-05-01 14:18:31 -05:00
Owner
Copy link

Why?

Why?
famfo commented 2022-05-01 14:20:17 -05:00
Author
Owner
Copy link

Because you don't escape textareas

Because you don't escape textareas
karx commented 2022-05-01 14:22:00 -05:00
Owner
Copy link

Where is that documented? All the examples on MDN use closing tags

Where is that documented? All the examples on MDN use closing tags
famfo commented 2022-05-01 14:28:14 -05:00
Author
Owner
Copy link

So I need to remake all textfields I have or what?

So I need to remake all textfields I have or what?
karx marked this conversation as resolved
famfo added 1 commit 2022-05-02 04:18:17 -05:00
famfo added 1 commit 2022-05-02 11:58:51 -05:00
famfo removed review request for lemonsh 2022-05-02 11:59:00 -05:00
famfo changed title from famfos-sql-fuckery to (draft) famfos-sql-fuckery 2022-05-02 12:00:49 -05:00
famfo added 1 commit 2022-05-02 12:03:27 -05:00
famfo commented 2022-05-11 04:46:18 -05:00
Author
Owner
Copy link

I guess this is a bit useless now with the actix rewrite 🐸

I guess this is a bit useless now with the actix rewrite 🐸
famfo closed this pull request 2022-05-11 04:46:18 -05:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: C4TG1RL5_UN1T3D/tmtd#2
No description provided.
Delete branch "famfos-sql-fuckery"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?