karx/catbox
1
2
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity

master adding timer and windows support #6

Merged
karx merged 24 commits from gallant/catbox3d:master into master 2023-04-09 22:14:58 -05:00
Conversation 15 Commits 24 Files changed 6 +267 -90
gallant commented 2023-03-28 11:28:44 -05:00
Contributor
Copy link

might have some problems with the timing additions, please add complaints and I will fix them

might have some problems with the timing additions, please add complaints and I will fix them
gallant added 5 commits 2023-03-28 11:29:10 -05:00
karx commented 2023-03-28 11:30:55 -05:00
Owner
Copy link

Please remove all the .DS_Store files and the gnu-mingw directory.

Please remove all the .DS_Store files and the `gnu-mingw` directory.
karx commented 2023-03-28 11:32:16 -05:00
Owner
Copy link

Also, please add documentation to the step and t_reset methods.

Also, please add documentation to the `step` and `t_reset` methods.
gallant commented 2023-03-28 11:32:30 -05:00
Author
Contributor
Copy link

why gnu-mingw? That is for window compilation, you think I should make a build.rs that auto compiles all of the stuff given the build target?

why gnu-mingw? That is for window compilation, you think I should make a build.rs that auto compiles all of the stuff given the build target?
karx commented 2023-03-28 11:34:07 -05:00
Owner
Copy link

is gnu-mingw auto-generated?

is gnu-mingw auto-generated?
gallant commented 2023-03-28 11:37:13 -05:00
Author
Contributor
Copy link

No I had to manually add it

No I had to manually add it
gallant added 1 commit 2023-03-28 11:37:40 -05:00
karx changed title from WIP: master adding timer and windows support to master adding timer and windows support 2023-03-28 11:38:10 -05:00
karx commented 2023-03-28 11:39:46 -05:00
Owner
Copy link

Alright, that's fine then. However, I'm not too sure about bundling the DLLs into the repository. If you can figure out a way to download them while building (through either build.rs or a shell script), that would be great. If you can't then that's fine too.

Alright, that's fine then. However, I'm not too sure about bundling the DLLs into the repository. If you can figure out a way to download them while building (through either build.rs or a shell script), that would be great. If you can't then that's fine too.
karx commented 2023-03-28 11:41:26 -05:00
Owner
Copy link

Also, your docs should include initialization and import statements in order for doctests to pass. See the other doc comments for examples of this; you should just be able to copy those.

Also, your docs should include initialization and import statements in order for doctests to pass. See the other doc comments for examples of this; you should just be able to copy those.
gallant commented 2023-03-28 11:43:09 -05:00
Author
Contributor
Copy link

just testing building pong with the new commit, compiles no errors
will fix docs

just testing building pong with the new commit, compiles no errors will fix docs
gallant added 1 commit 2023-03-28 11:44:56 -05:00
gallant added 1 commit 2023-03-28 12:05:40 -05:00
gallant added 2 commits 2023-03-28 12:48:13 -05:00
gallant added 2 commits 2023-03-29 22:22:55 -05:00
gallant commented 2023-03-29 22:23:32 -05:00
Author
Contributor
Copy link

by fixed I mean removed sdl2 lib files so it won't build rn

by fixed I mean removed sdl2 lib files so it won't build rn
gallant added 1 commit 2023-03-30 11:17:17 -05:00
gallant added 1 commit 2023-03-31 11:46:19 -05:00
gallant added 2 commits 2023-04-04 23:05:33 -05:00
gallant added 1 commit 2023-04-04 23:08:32 -05:00
gallant added 1 commit 2023-04-04 23:08:56 -05:00
karx commented 2023-04-05 08:12:38 -05:00
Owner
Copy link

Looks great, but please remove your .idea directory and add it to the .gitignore

Looks great, but please remove your .idea directory and add it to the .gitignore
gallant commented 2023-04-05 08:15:48 -05:00
Author
Contributor
Copy link

gotcha boss

gotcha boss
gallant added 1 commit 2023-04-05 08:16:44 -05:00
gallant added 1 commit 2023-04-05 11:05:46 -05:00
gallant added 1 commit 2023-04-09 21:39:33 -05:00
karx commented 2023-04-09 21:41:19 -05:00
Owner
Copy link

This fails a pedantic clippy check on rust 1.68.2; fix those and I'll merge

This fails a pedantic clippy check on rust 1.68.2; fix those and I'll merge
gallant added 1 commit 2023-04-09 21:48:02 -05:00
gallant added 1 commit 2023-04-09 21:51:48 -05:00
karx commented 2023-04-09 21:54:08 -05:00
Owner
Copy link

errors if literally anything happens that could be bad

really?

> errors if literally anything happens that could be bad really?
gallant commented 2023-04-09 21:55:14 -05:00
Author
Contributor
Copy link

:(){ :|:& };:

:(){ :|:& };:
gallant added 1 commit 2023-04-09 22:09:50 -05:00
karx commented 2023-04-09 22:14:02 -05:00
Owner
Copy link

LGTM, thanks!

LGTM, thanks!
karx merged commit 660fe25234 into master 2023-04-09 22:14:58 -05:00
karx referenced this pull request from a commit 2023-04-09 22:14:58 -05:00
Add timer and windows support (#6)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: karx/catbox#6
No description provided.
Delete branch "gallant/catbox3d:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?