missing/dyn_vec
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

found the soundness hole

Browse source
This commit is contained in:
missing 2022-08-14 18:31:10 -05:00
parent 63c28955aa
commit 7e743be9d8
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/impls.rs
View file

@ -6,6 +6,7 @@ use std::{
fmt::Debug,
mem::size_of,
ops::{Deref, DerefMut},
ptr::NonNull,
slice,
vec::Vec as StdVec,
};
@ -161,13 +162,21 @@ impl<T> Deref for Vec<T> {
type Target = [T];
fn deref(&self) -> &Self::Target {
unsafe { slice::from_raw_parts(self.get_ptr(0), self.len) }
if self.is_empty() {
unsafe { slice::from_raw_parts(NonNull::dangling().as_ptr(), 0) }
} else {
unsafe { slice::from_raw_parts(self.get_ptr(0), self.len) }
}
}
}
impl<T> DerefMut for Vec<T> {
fn deref_mut(&mut self) -> &mut Self::Target {
unsafe { slice::from_raw_parts_mut(self.get_ptr(0) as _, self.len) }
if self.is_empty() {
unsafe { slice::from_raw_parts_mut(NonNull::dangling().as_ptr(), 0) }
} else {
unsafe { slice::from_raw_parts_mut(self.get_ptr(0) as _, self.len) }
}
}
}