When resizing, the embedded client is being resized to (height = wh - bh),
which is (<= 0) if (wh <= bh). This generates a BadValue Error leading to a
crash. This patch fixes that by hiding the tab bar if the window height is too
small, and also sets a min_height WM hint to prevent that situation from
happening in the first place.
Hello, this is useful when you want to use the same key binding that closes windows to close tabs. I got tired of loosing my tabbed/surf session when I hit my WM's close key. "Last tab" behavior still respects -c/-f.
Cheers
-J
From 829e95855f0fe78a368788a5e72231bd6456a8cf Mon Sep 17 00:00:00 2001
From: jakeogh <github.com@v6y.net>
Date: Mon, 21 Mar 2016 01:36:28 +0000
Subject: [PATCH] add -k to close foreground tabbed client on WM_DELETE_WINDOW
Signed-off-by: Christoph Lohmann <20h@r-36.net>
When tabbed becomes urgent because one of it tabs becomes urgent, it
may be desireable to automatically focus that tab. As a notification may
be lost, if another notification comes in before you focused tabbed, the
switch is only done, if tabbed is not urgent already.
Moreover, it may be anoying, if you just type into one tab, another tab
gets urgent -therfore focused- and you type into the other tab, you may
switch between autofocus and nofocus using Ctrl-Shift-u.
Maybe it would also be usefull, if there would be an commandline
parameter to toggle that option, but as -u is already used for
urgent-tab-color, i did not implement that.
Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
Signed-off-by: Christoph Lohmann <20h@r-36.net>
With a lot of open tabs its quite annoying to toggle through all tabs
until reaching the next one with an urgent hint set. Also with using
Ctrl-[0..9] to get to the first 10 tabs, in some cases this may have
disadvantages:
1. with more than 10 tabs, you can not use that quickselection
2. with a small tabbed window, you do not see every tab in the
statusbar and therefore do not know which tab got urgent
Therefore I created a function, which iterates over all currently
managed tabs, focus the first urgent tab found or stays at the current
tab, if there is no urgent-tab. By default, that function is mapped to
Ctrl-u.
Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
Signed-off-by: Christoph Lohmann <20h@r-36.net>
xembed will cause a command to attempt to XEmbed into the window given
by the environment variable XEMBED, so long as it is in the foreground
of its controlling terminal. This causes a process to effectively take
the place of the terminal window, unless it is backgrounded.
Signed-off-by: Christoph Lohmann <20h@r-36.net>
Before this patch, movetab() just switched positions of the selected tab with
the new position. This resulted in unexpected behaviour when „moving“ a tab over
one end of the list.
Now tabs are moved correctly by the specified amount of indizes.
Signed-off-by: Christoph Lohmann <20h@r-36.net>
Hi,
Simple patch for tabbed that prevents tabbed from killing a client that it
should no longer be managing due to an UnmapNotify event.
Add support for UnmapNotify; allows a window to map and unmap without
needing it to be destroyed.
Thanks,
Okan
Signed-off-by: Christoph Lohmann <20h@r-36.net>
- Run "tabbed xterm -into".
- Open a new tab using Ctrl+Shift+Enter, switch to it using Ctrl+Tab.
- Run "sleep 2; printf '\a'".
- Quickly change back to the first tab (c = 0) and wait for the second
one (c = 1) to get the urgency hint.
- Close the first tab using Ctrl+Q or Ctrl+D. This sets sel = 0 and c =
0, so focus() won't touch the urgency hint.
- Now, the urgency hint on the second tab has not been cleared. Open a
new tab to verify it.
Signed-off-by: Christoph Lohmann <20h@r-36.net>
The default config will display all open tabs in dmenu. You can either select
one of them, or if you enter a string, that does not start with „0x“, tabbed
will open a new tab and run the command specified at tabbed-startup but append
the entered string to the command first.
With
tabbed -r 2 surf -e ''
you can hit Ctrl-T and either select an already opened tab or enter an URL,
which will be opened in a new tab with surf.
Signed-off-by: Christoph Lohmann <20h@r-36.net>
This crops up whenever you just switched from tab # N+1 to tab # N
and close current tab. unmanage() first decreases lastsel
(so it becomes N) then erroneously tests it against sel and focuses first tab
instead. One can see that focus() would never set lastsel == sel,
so I took liberty to fix this annoying behaviour which happens to frequently
with newposition = 0 and npisrelative = True settings.
Signed-off-by: Christoph Lohmann <20h@r-36.net>
Ahoy,
the attached patch fixes a tiny issue with tabbed. When running it
without a command and having it run spawn(), it tried to execute its
window ID as a command. While most people probably don't have
executables called 341123 or the like in their path, I think that is not
exactly intended. The following patch fixes that:
From c7ade36f8ef6429546ad89bc9ab479fa44c4790a Mon Sep 17 00:00:00 2001
From: Gregor Best <gbe@ring0.de>
Date: Sun, 7 Jul 2013 20:36:06 +0200
Subject: [PATCH] Don't set cmd[0] to the window ID
Starting tabbed without a command sets cmd[0] to the window ID of
tabbed. This leads to funky errors such as "execvp: <ID> failed: no such
file or directory" when running spawn().
Signed-off-by: Gregor Best <gbe@ring0.de>
Signed-off-by: Christoph Lohmann <20h@r-36.net>
Yash Karandikar
mikau
Lucas Gabriel Vuotto
Alessandro Caputo
Caleb Malchik
Quentin Rameau
Christoph Lohmann
Justin Keogh
Lucas Gabriel Vuotto
Jonas Rabenstein
Connor Lane Smith
Markus Teich
Okan Demirmen
Peter Hofmann
noname
Gregor Best
Alexander Sedov