From 6cb78120d4f9450e7374bcaa637e76ab8944affc Mon Sep 17 00:00:00 2001 From: Sam Lantinga Date: Tue, 15 Dec 2020 00:42:17 -0800 Subject: [PATCH] Fixed bug 5399 - make install is broken as it depends on missing rule `build` Stephen Broadfoot I've tracked this down to the following changeset bb65ba8e039b https://hg.libsdl.org/SDL/diff/bb65ba8e039b/Makefile.in this changeset renames the rule `build` to `build/.created` but the rule `install-lib` still depends on the rule `build` This affects users who are trying to install via homebrew who are installing via source and not by the bottle as this invokes `make install` To be clear, the error I was hitting when running make install is make: *** No rule to make target `build', needed by `install-lib'. Stop. --- Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.in b/Makefile.in index 834e7c6a4..57871bedf 100644 --- a/Makefile.in +++ b/Makefile.in @@ -178,7 +178,7 @@ install-hdrs: update-revision $(INSTALL) -m 644 $(srcdir)/include/SDL_revision.h $(DESTDIR)$(includedir)/SDL2/SDL_revision.h; \ fi -install-lib: $(objects) $(objects)/$(TARGET) $(objects)/$(SDLMAIN_TARGET) $(objects)/$(SDLTEST_TARGET) +install-lib: $(objects)/$(TARGET) $(objects)/$(SDLMAIN_TARGET) $(objects)/$(SDLTEST_TARGET) $(SHELL) $(auxdir)/mkinstalldirs $(DESTDIR)$(libdir) $(LIBTOOL) --mode=install $(INSTALL) $(objects)/$(TARGET) $(DESTDIR)$(libdir)/$(TARGET) $(LIBTOOL) --mode=install $(INSTALL) $(objects)/$(SDLMAIN_TARGET) $(DESTDIR)$(libdir)/$(SDLMAIN_TARGET)