circe/async-circe
2
0
Fork 0
Code Issues 1 Pull requests Projects Releases Wiki Activity

[bug] Entire TCP packet being received as a single command #1

New issue
Closed
opened 2022-01-01 13:58:31 -06:00 by lemonsh · 1 comment
lemonsh commented 2022-01-01 13:58:31 -06:00
Copy link

async-circe currently uses AsyncReadExt::read() to read a line from the TCP stream, but that method in no way guarantees how many bytes it will read. Effectively, this can lead to a complete desynchronization of the protocol exchange if read() happens to finish even one byte before the CRLF.

Here's an example of circe reading an optimized (by the IRCd) TCP packet containing multiple messages:

2022-01-01T19:34:18.405477Z DEBUG async_circe::commands: 0466737e393c.karx.xyz 375 uberbot2 :0466737e393c.karx.xyz message of the day
:0466737e393c.karx.xyz 372 uberbot2 :          _                     ___ ____   ____ 
:0466737e393c.karx.xyz 372 uberbot2 :         | | ____ _ _ ____  __ |_ _|  _ \ / ___|
:0466737e393c.karx.xyz 372 uberbot2 :         | |/ / _` | '__\ \/ /  | || |_) | |    
:0466737e393c.karx.xyz 372 uberbot2 :         |   < (_| | |   >  <   | ||  _ <| |___ 
:0466737e393c.karx.xyz 372 uberbot2 :         |_|\_\__,_|_|  /_/\_\ |___|_| \_\____|

where one log message corresponds to many actual IRC messages.

async-circe currently uses AsyncReadExt::read() to read a line from the TCP stream, but that method in no way guarantees how many bytes it will read. Effectively, this can lead to a complete desynchronization of the protocol exchange if read() happens to finish even one byte before the CRLF. Here's an example of circe reading an optimized (by the IRCd) TCP packet containing multiple messages: ``` 2022-01-01T19:34:18.405477Z DEBUG async_circe::commands: 0466737e393c.karx.xyz 375 uberbot2 :0466737e393c.karx.xyz message of the day :0466737e393c.karx.xyz 372 uberbot2 : _ ___ ____ ____ :0466737e393c.karx.xyz 372 uberbot2 : | | ____ _ _ ____ __ |_ _| _ \ / ___| :0466737e393c.karx.xyz 372 uberbot2 : | |/ / _` | '__\ \/ / | || |_) | | :0466737e393c.karx.xyz 372 uberbot2 : | < (_| | | > < | || _ <| |___ :0466737e393c.karx.xyz 372 uberbot2 : |_|\_\__,_|_| /_/\_\ |___|_| \_\____| ``` where one log message corresponds to many actual IRC messages.
famfo commented 2022-01-02 02:59:12 -06:00
Owner
Copy link

fixed by #df4a7a7ce

fixed by #df4a7a7ce
famfo closed this issue 2022-01-02 02:59:12 -06:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
refactor
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: circe/async-circe#1
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?